JBR-7072 Wayland: clicks on items of floating context menus are ignored #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth creating an automated test case? Or at least a simple reproducer for manual checking, not requiring to launch the IDE? |
Yes, I attached a manual test to the issue here. |
I think that a manual jtreg test would be useful here. We have too many reproducers inside the issue without at least a semi-automated way to verify them. |
|
I added a manual test. It can be run on Wayland like so |
avu
approved these changes
Jun 13, 2024
| @@ -0,0 +1,125 @@ | |||
| /* | |||
| * Copyright 2024 JetBrains s.r.o. | |||
There was a problem hiding this comment.
Usually we use
- Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
as well
JB-Dmitry
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBR-7072 Wayland: clicks on items of floating context menus are ignored
The origin of the problem lies in an unexpected sequence of FocusEvent's generated on the popup invocation. In order to make that sequence more standard, I used the corresponding method from LWComponentPeer as a template. It doesn't cover all Wayland cases yet and falls through to
WLKeyboardFocusManagerPeer.SNFH_FAILUREcase in some instances, but that's a task for another day.Also verified that this fix did not regress on the test from JBR-6145 [Wayland toolkit] Popup windows aren't focusable.