JBR-7305 Vulkan: Implement FILL_SPANS primitive for flat color rendering #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avu
force-pushed
the
avu/jbr21-JBR-7305-FILL_SPANS
branch
from
aa67b3f
to
d56b480
Compare
Implemented flat color shape rendering
avu
force-pushed
the
avu/jbr21-JBR-7305-FILL_SPANS
branch
from
d56b480
to
2e6116f
Compare
YaaZ
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
The only major difference between all plain-color rendering commands is the calculation of primitive coordinates, in the future we could refactor the common code, so that actual rendering function would look like:
Vertex* verts = writeVertices(numVertices);- Write coordinates into
verts flushVertices();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented flat color shape rendering