Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Loading Image ByteArray During Preprocessing #321

Closed
AlexandreBrown opened this issue Dec 30, 2021 · 4 comments
Closed

Add Support For Loading Image ByteArray During Preprocessing #321

AlexandreBrown opened this issue Dec 30, 2021 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@AlexandreBrown
Copy link

Currently we are forced to pass in a File when loading an image in the preprocess DSL.
It would be great to support the use case where we already have the images loaded and ready in memory instad of requiring to save them to the disk. This avoids a round trip to the disk and makes it more convenient to the user of the library.

@zaleslaw
Copy link
Collaborator

Thanks to the issue and proposed PR for this issue, we need to design in this place a better architecture to add new data sources more easily than now. It will be supported in the release 0.4

@AlexandreBrown
Copy link
Author

@zaleslaw Hello, was this added in 0.4?

@zaleslaw
Copy link
Collaborator

zaleslaw commented Jun 9, 2022

@AlexandreBrown Unfortunately, it was not included

@zaleslaw zaleslaw added this to the 0.5 milestone Jun 9, 2022
@zaleslaw zaleslaw added the enhancement New feature or request label Jun 9, 2022
@juliabeliaeva
Copy link
Collaborator

Issue became obsolete since the new more flexible preprocessing dsl was implemented in #425. Dataset api also allows to accept different sources now with the DataLoader abstraction introduced in #424.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants