-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Mish Activation Function #173
Conversation
@zaleslaw This is ready for review. |
Many thanks for the contribution, @digantamisra98 I'll run the TC and merge it if it is successful |
@@ -215,6 +215,26 @@ public enum class Activations { | |||
*/ | |||
Swish; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
; -> , due to enum in Kotlin https://kotlinlang.org/docs/enum-classes.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you compile the Kotlin code or just added rows in the Notepad++? Because the code could not be compiled on TC servers
> Task :api:compileKotlin
13:45:25 :api:compileKotlin
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/activation/Activations.kt: (234, 5): Expecting member declaration
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/activation/Activations.kt: (234, 5): Expecting member declaration
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/activation/Activations.kt: (258, 17): Unresolved reference: Mish
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/activation/Activations.kt: (258, 17): Unresolved reference: Mish
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelLoader.kt: (430, 9): Unresolved reference: ACTIVATION_MISH
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelLoader.kt: (430, 40): Unresolved reference: Mish
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelSaver.kt: (270, 21): Unresolved reference: Mish
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelLoader.kt: (430, 9): Unresolved reference: ACTIVATION_MISH
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelSaver.kt: (270, 29): Unresolved reference: ACTIVATION_MISH
13:45:47
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelLoader.kt: (430, 40): Unresolved reference: Mish
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelSaver.kt: (270, 21): Unresolved reference: Mish
13:45:47 e: /mnt/agent/work/c1e3495e9fda7093/api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ModelSaver.kt: (270, 29): Unresolved reference: ACTIVATION_MISH
13:45:47 > Task :api:compileKotlin FAILED
Not compiled again, ok, I'll help to finish this request, clone your branch tomorrow and resolve the issue. |
@digantamisra98 Just add the following line to the internal const val ACTIVATION_MISH: String = "mish" |
Thanks, @digantamisra98, for the contribution and @mkaze for the advice! |
Resolves 168 and adds Mish Activation Function.