Allow Anchor for custom actions #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an additional method to the BaseApplicationPlugin that allows to specify an anchor when adding actions to a existing group. This can be used in custom generators for actions to to actions at a specific position in an existing group. It should not break any existing implementations because the default behavior is preserved for existing callers. There is a second patch to this which will extend the actions language to make direct use of this functionality which I will sent later. Since it is a bigger change to the language I will sent a second pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional method to the BaseApplicationPlugin that allows
to specify an anchor when adding actions to a existing group.
This can be used in custom generators for actions to to actions at a
specific position in an existing group. It should not break any
existing implementations because the default behavior is preserved for
existing callers.
There is a second patch to this which will extend the actions language
to make direct use of this functionality which I will sent later. Since
it is a bigger change to the language I will sent a second pull request.