Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R6 library support [part 3] #3

Closed
wants to merge 53 commits into from
Closed

R6 library support [part 3] #3

wants to merge 53 commits into from

Conversation

DeagleGross
Copy link
Contributor

Hello!

I am contributing R6 library support as my diploma project.
My mentor is @vedun-z.

This is a [part 3] pull-request. Others are made in Rkernel-proto and Rkernel repositories.

@DeagleGross
build rplugin with R6 base classes on linux
1605b5a
@DeagleGross
loaded all R packages and success in dummy tests
050ba62
@DeagleGross
add test and full r6 class definition
61ceab9
@DeagleGross
changed definitions of R6 content due to unsupported overloading
091de92
@DeagleGross
added getting r6ClassFields API
dff992e
@DeagleGross
added getting r6ClassMethods API
9c3a013
@DeagleGross
r6 utils implemented and tested
723a055
@DeagleGross
defined classes for completions and context
344cf53
@DeagleGross
add r6 description to service.proto of RKernel
768d7e7
@DeagleGross
inserting logic to RReferenceImpl.kt
36bca8b
@DeagleGross
tests classes refactor and add r6 tests (not ready)
64b61dd
@DeagleGross
trying to build references impl
2532669
@DeagleGross
find usages from used class members working
3db2904
@DeagleGross
fix faster return from processing searched identifier
38a12c1
@DeagleGross
all other symbols placement handled
838d359
@DeagleGross
implemented completion for r6ClassMembers. Tested statically (not run…
ead0f81 
…time)
@DeagleGross
temporary directory for sharing other configuration files (service.pr…
51737dd 
…oto).
@DeagleGross
rename and navigation works
4c05dff
@DeagleGross
refactor contexts
b7256a0
@DeagleGross
refactor classNameIndexes
9e708df
@DeagleGross
fix base class library context provider
75eb6ce
@DeagleGross
refactoring moving along Psi dataStructure
ba29305
@DeagleGross
removed unused provider
2d40380
@DeagleGross
rollback refactoring changes for fixing
67f18b0
@DeagleGross
clearing null asserting in RS4ClassInfoUtil
d02daf1
@DeagleGross
minor changes
34becb7
@DeagleGross
create provider and instances of indexes
e1b2707
@DeagleGross
completion refactor + class name suggestion
62eb547
@DeagleGross
R6Class contains whole superclass hierarchy
793fb07
@DeagleGross
superclass members analysis completed
0f8e7d7
This was referenced Apr 25, 2021
Closed
Closed
@DeagleGross DeagleGross marked this pull request as ready for review April 25, 2021 21:37
@DeagleGross

This comment has been minimized.

Sign in to view
@vladimir-koshelev
Copy link
Collaborator

Could you please use git rebase -i in order to prettify the commit history?

@DeagleGross
Copy link
Contributor Author

DeagleGross commented Apr 30, 2021 •
edited

General remarks from @vedun-z

  • ILibraryClassContext remove for R6 and S4
  • R6ContextProvider and RS4ContextProvider -> define specific providers directly in getProviders call
  • remove stubs\classes inheritance -> back to static functions
  • service.proto define fields and methods separately and extend interface RLookupElementInsertHandler for completing functions with ()
  • prettify commits history using git rebase -i

UPD @vedun-z :

  • fixed all above except ILibraryContext - I've tried to remove it, but code felt a little bit awkward to me. Please, leave a comment if you still think it is unneeded.
  • also I've squashed commits into single one, but Git still shows full history.

@vladimir-koshelev
Copy link
Collaborator

Merged: 4706a20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-koshelev vladimir-koshelev vladimir-koshelev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@DeagleGross @vladimir-koshelev