"SonarQube Branches & Pull Requests" feature displays configuration logs more than once

[axel3rd]

Currently, the header configuration log is displayed more than once (one by step in fact):

[13:01:16] SonarQube plugin detects pull-request, 'env.SONARQUBE_SCANNER_PARAMS' set with '{"sonar.pullrequest.key":"42","sonar.pullrequest.branch":"Foo bar","sonar.pullrequest.base":"master","sonar.pullrequest.provider":"github","sonar.pullrequest.github.repository":"foo/bar"}'
[13:01:16] SonarQube plugin detects pull-request, 'env.SONARQUBE_SCANNER_PARAMS' set with '{"sonar.pullrequest.key":"42","sonar.pullrequest.branch":"Foo bar","sonar.pullrequest.base":"master","sonar.pullrequest.provider":"github","sonar.pullrequest.github.repository":"foo/bar"}'
[13:01:16] SonarQube plugin detects pull-request, 'env.SONARQUBE_SCANNER_PARAMS' set with '{"sonar.pullrequest.key":"42","sonar.pullrequest.branch":"Foo bar","sonar.pullrequest.base":"master","sonar.pullrequest.provider":"github","sonar.pullrequest.github.repository":"foo/bar"}'
[13:01:16] SonarQube plugin detects pull-request, 'env.SONARQUBE_SCANNER_PARAMS' set with '{"sonar.pullrequest.key":"42","sonar.pullrequest.branch":"Foo bar","sonar.pullrequest.base":"master","sonar.pullrequest.provider":"github","sonar.pullrequest.github.repository":"foo/bar"}'
[13:01:16] SonarQube plugin detects pull-request, 'env.SONARQUBE_SCANNER_PARAMS' set with '{"sonar.pullrequest.key":"42","sonar.pullrequest.branch":"Foo bar","sonar.pullrequest.base":"master","sonar.pullrequest.provider":"github","sonar.pullrequest.github.repository":"foo/bar"}'
[13:01:16] SonarQube plugin detects pull-request, 'env.SONARQUBE_SCANNER_PARAMS' set with '{"sonar.pullrequest.key":"42","sonar.pullrequest.branch":"Foo bar","sonar.pullrequest.base":"master","sonar.pullrequest.provider":"github","sonar.pullrequest.github.repository":"foo/bar"}'
[13:01:16] SonarQube plugin detects pull-request, 'env.SONARQUBE_SCANNER_PARAMS' set with '{"sonar.pullrequest.key":"42","sonar.pullrequest.branch":"Foo bar","sonar.pullrequest.base":"master","sonar.pullrequest.provider":"github","sonar.pullrequest.github.repository":"foo/bar"}'
[13:01:16] SonarQube plugin detects pull-request, 'env.SONARQUBE_SCANNER_PARAMS' set with '{"sonar.pullrequest.key":"42","sonar.pullrequest.branch":"Foo bar","sonar.pullrequest.base":"master","sonar.pullrequest.provider":"github","sonar.pullrequest.github.repository":"foo/bar"}'

---

But log "SonarQube plugin detects [pull-request|branch], 'env.SONARQUBE_SCANNER_PARAMS' set with ..." is displayed 3 times ... I should understand why 😒

Fixed by Execute process once (and not 4 each steps). It was because ParametersPreprocessor is executed for each steps of build.

Initial implementation (#77) has not fixed the problem.

---

TeamCity.SonarQubePlugin/sonar-plugin-server/src/main/java/jetbrains/buildserver/sonarplugin/buildfeatures/BranchesAndPullRequestsParametersPreprocessor.java

Lines 42 to 45 in eb0d53d

	if (build.getBuildFeaturesOfType(BranchesAndPullRequestsBuildFeature.BUILD_FEATURE_TYPE).isEmpty() || buildParams.containsKey(SQS_SYSENV)) {
	// Currently only GitHub is supported => if feature defined, it is for GitHub
	// ParametersPreprocessor is called for each steps (or could be defined manually). So if sysenv already defined, skip process.
	return;

The code seems executed at same time => sysenv flag is not suffisant.

Adding a block synchronize is perhaps the solution. @Linfar : Is it tolerable in a ParametersPreprocessor ?

[Linfar]

Synchronization can only solve problems caused by several threads concurrently modifying a shared state. Here there is only one thread initializing AgentBuild so synchronization won't help. Since runParameters isn't used anyway then probably BranchesAndPullRequestsParametersPreprocessor could be rewritten to BuildStartContextProcessor?

[axel3rd]

I'm currently /OOO, but I will try to achieve that this month.

[axel3rd]

Historical link: commit 0b78ca0

[axel3rd]

Fixed by #84 (merged)