Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riderlink won't build UE5 C++17 even with _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS #130

Closed
chadmv opened this issue Sep 7, 2021 · 1 comment

Comments

@chadmv
Copy link

chadmv commented Sep 7, 2021

I have Rider for Unreal Engine 2021.2
Build #RDCPPP-212.4746.131, built on August 6, 2021
Non-Bundled Plugins: unreal-link (2021.2.0.603), com.microsoft.vso.idea (1.161.2)

I am trying to build with UE5-main ad5808d

I saw the issue in #109 and can see in the RD.Build.cs it has PublicDefinitions.Add("_SILENCE_ALL_CXX17_DEPRECATION_WARNINGS");

However I can't build Riderlink as I still see a bunch of C++17 errors. The messages all say to add the _SILENCE_ALL_CXX17_DEPRECATION_WARNINGS definition which I see is already defined. Any suggestions?

idea.log

@chadmv
Copy link
Author

chadmv commented Sep 17, 2021

Issue seems to have been resolved at least as of 71b1485. The warnings still appear though.

@chadmv chadmv closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant