Material 3 DropdownMenu Skiko support #347
Conversation
| // so we need to make additional checks and adjust the position of the [DropdownMenu] to | ||
| // avoid content being cut off if the [DropdownMenu] contains too many items. | ||
| // See: https://github.com/JetBrains/compose-jb/issues/1388 | ||
| val popupPositionProvider = SkikoDropdownMenuPositionProvider( |
There was a problem hiding this comment.
This has diverged from DropdownMenuPositionProvider which now handles LTR. If you want, I can make a followup PR that ports that behavior here and into the material DesktopDropdownMenuPositionProvider.
There was a problem hiding this comment.
That would be great, thanks.
P.S. Doesn't it handle LTR already? We have if (layoutDirection == LayoutDirection.Ltr) in the DesktopDropdownMenuPositionProvider/SkikoDropdownMenuPositionProvider
There was a problem hiding this comment.
Oh interesting, guess I missed that 😅
|
@igordmn any chance this makes it into 1.3.0? |
|
Hi, thanks for the changes! I will look at your PR's soon. In the meantime, could you look at this comment, and do what is asked there (sign CLA, put "CLA is signed" in the PR description), and agree on the terms? |
|
Updated description regarding CLA and I agree that author fields can be lost |
|
Do I need to do this for all my open PRs? |
Yes, just add "CLA is signed" into them |
Proposed Changes
Popupfrom desktop and uikit with aPopupin skikoDropdownMenuto material3 for skikoTesting
Test: Copied the
DesktopMenuTestfrom material into material3; keptDesktopPopupTestinui/desktopTestwhich now usesPopupfrom skiko, since I couldn't get the tests to pass inui/skikoTest(got everything to compile, but couldn't figure out how to idle withImageComposeScene; maybe related to JetBrains/compose-multiplatform#1866)Issues Fixed
Addresses JetBrains/compose-multiplatform#2037
Possibly supersedes #328
CLA is signed