MD3 native dropdown support #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blazsolar
force-pushed
the
md3-uikit-dropdown
branch
from
2f39e40
to
d74641a
Compare
igordmn
reviewed
Dec 5, 2022
| onDismissRequest = onDismissRequest, | ||
| popupPositionProvider = popupPositionProvider, | ||
| onPreviewKeyEvent = onPreviewKeyEvent, | ||
| onKeyEvent = onKeyEvent, |
There was a problem hiding this comment.
DesktopMenu.desktop.kt has additional logic here. Let's copy it here too.
| * [Interaction]s and customize the appearance / behavior of this menu item in different states. | ||
| */ | ||
| @Composable | ||
| fun DropdownMenuItem( |
There was a problem hiding this comment.
Better to not commonize public functions without commonizing them in the original androidx repository first. It can cause issues. Let's just copy it to uikitMain for now.
Commonization of DropdownMenu is a separate issue
| modifier: Modifier = Modifier, | ||
| offset: DpOffset = DpOffset(0.dp, 0.dp), | ||
| onPreviewKeyEvent: ((KeyEvent) -> Boolean) = { false }, | ||
| onKeyEvent: ((KeyEvent) -> Boolean) = { false }, |
There was a problem hiding this comment.
We probably need to add these parameters to another implementations first, and only then here. The order of parameters may change (because of preserving backward compatibility for the old implementations)
If you don't need them, let's not add them for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding dropdown support for native target in material 3 library.
CLA is signed