Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Explorer] Deleting SQL Server does not delete the SQL Server instance #133

Closed
sdubov opened this issue Dec 21, 2018 · 1 comment
Closed

[Azure Explorer] Deleting SQL Server does not delete the SQL Server instance #133

sdubov opened this issue Dec 21, 2018 · 1 comment
Assignees
@sdubov
Labels
bug Something isn't working
Milestone
183.1

Comments

@sdubov
Copy link
Collaborator

sdubov commented Dec 21, 2018 •
edited

Calling Delete action for SQL Server in Azure explorer does not delete the SQL Server instance (it removes only node leaf).

Steps to reproduce:

  1. Login to Azure account
  2. Make sure there are some SQL Servers under "Databases" node in Azure Explorer
  3. Right click any SQL Server and select "Delete"

Expected: SQL Server instance is deleted from Azure and is not visible in the Azure Explorer
Actual: SQL Server node is removed, but it appears again after refreshing. Azure instance still exists.
@sdubov sdubov self-assigned this Dec 21, 2018
@sdubov sdubov added the bug Something isn't working label Dec 21, 2018
@sdubov sdubov modified the milestones: 183.1, 191 Dec 21, 2018
sdubov added a commit that referenced this issue Dec 21, 2018
@sdubov
Fix #134, #135. Add ability to create SQL Server and SQL Database fro…
0eda60e 
…m Azure Explorer

- Fix #134. Add Create SQL Server dialogs available from Azure Explorer from Databases node
- Fix #135. Add Create SQL Database dialog available from Azure Explorer from SQL Server node
- Fix issues #133
- Add custom components for Subscription, Resource Group, App Service Plan, SQL Server and helpers
- Refactor validation logic - move all common logic into a separate validators and add wrappers for Run configuraiton and dialogs validation
- Move AzureDatabaseMvpModel into plugin Utils project and refactor related logic
- Generalize Azure Notification constants available in Azure Event Log
sdubov added a commit that referenced this issue Dec 21, 2018
@sdubov
Fix #134, #135. Add ability to create SQL Server and SQL Database fro…
23cac6c 
…m Azure Explorer

- Fix #134. Add Create SQL Server dialogs available from Azure Explorer from Databases node
- Fix #135. Add Create SQL Database dialog available from Azure Explorer from SQL Server node
- Fix issues #133
- Add custom components for Subscription, Resource Group, App Service Plan, SQL Server and helpers
- Refactor validation logic - move all common logic into a separate validators and add wrappers for Run configuraiton and dialogs validation
- Move AzureDatabaseMvpModel into plugin Utils project and refactor related logic
- Generalize Azure Notification constants available in Azure Event Log
@sdubov sdubov mentioned this issue Dec 21, 2018
Merged
sdubov added a commit that referenced this issue Jan 9, 2019
@sdubov
Fix #133
ab1c93f
@sdubov sdubov mentioned this issue Jan 9, 2019
Closed
@sdubov
Copy link
Collaborator Author

sdubov commented Jan 10, 2019

Fixed in 183.1 branch.

@sdubov sdubov closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdubov sdubov

Labels
bug Something isn't working
Projects
None yet
Milestone
183.1
Development

No branches or pull requests
1 participant
@sdubov