[feature] build_flags support in project view
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrams27
force-pushed
the
issue-175
branch
7 times, most recently
from
7cb302f
to
242eb98
Compare
abrams27
changed the title
build_flag support in project view
abrams27
changed the title
build_flag support in project viewbuild_flags support in project view
# Conflicts: # executioncontext/projectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewTest.java # executioncontext/projectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/sections/ProjectViewListSectionTest.java # executioncontext/projectview/src/test/java/org/jetbrains/bsp/bazel/projectview/parser/ProjectViewParserImplTest.java # executioncontext/projectview/src/test/java/org/jetbrains/bsp/bazel/projectview/parser/sections/ProjectViewListSectionParserTest.java
# Conflicts: # CHANGELOG.md # bazelrunner/src/main/java/org/jetbrains/bsp/bazel/bazelrunner/BazelRunner.java # server/src/main/java/org/jetbrains/bsp/bazel/server/BazelBspServer.java # server/src/main/java/org/jetbrains/bsp/bazel/server/bsp/config/ServerArgsProjectViewProvider.java
lukaszwawrzyk
approved these changes
Apr 10, 2022
lukaszwawrzyk
approved these changes
Apr 10, 2022
# Conflicts: # bazelrunner/src/main/java/org/jetbrains/bsp/bazel/bazelrunner/BazelRunner.java # executioncontext/projectview/src/main/java/org/jetbrains/bsp/bazel/projectview/parser/ProjectViewParserImpl.java # executioncontext/projectview/src/test/java/org/jetbrains/bsp/bazel/projectview/parser/ProjectViewParserImplTest.java # junit5.bzl # server/src/main/java/org/jetbrains/bsp/bazel/server/BazelBspServer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_flagssupport!I had to update (a bit) project view parsers : ( - so there are multiple edited files
fixes #175
testing:
and manual testing (on this repo: https://github.com/bazelbuild/intellij)