[feature] output forwarding from bazel processes #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszwawrzyk
force-pushed
the
output-forward
branch
2 times, most recently
from
f1d3a20
to
099cef5
Compare
abrams27
reviewed
Mar 21, 2022
|
ohh and I thing that it would be nice to color (or make it bold if it is possible) |
abrams27
reviewed
Mar 21, 2022
bazelrunner/src/main/java/org/jetbrains/bsp/bazel/bazelrunner/BazelProcess.java
Outdated
Show resolved
Hide resolved
I think I have a race condition. Working on a fix. |
The problem is that the sync console displays color but the build console doesn't (and you see some unprintable characters). So I just carefully enabled colors only on calls when it is useful and displays in sync console. If I colored the Invoking it would not always display correctly :/ |
lukaszwawrzyk
force-pushed
the
output-forward
branch
from
099cef5
to
9fbe5bf
Compare
abrams27
approved these changes
Mar 21, 2022
abrams27
changed the title
added 2 commits
March 22, 2022 10:46
lukaszwawrzyk
force-pushed
the
output-forward
branch
from
9fbe5bf
to
37543e2
Compare
abrams27
reviewed
Mar 22, 2022
bazelrunner/src/main/java/org/jetbrains/bsp/bazel/bazelrunner/utils/Stopwatch.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, each bazel process run with
BazelRunner(whenwaitAndGetResult()is called) will send log message to bsp-client:Running: [command] and forward stdout and stderr. The output is also collected to string and lines list for later use.
PR also includes some refactoring to vavr, refactoring of bazel flags etc.
I also replaced includedTargets and excludedTargets pair with single class TargetSpecs. In the future I imagine it as the main way to specify what should be built/run. It can also contain directories to derive targets from. Bazel runner could resolve what to run and run it.