[feature] manual tag support #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
April 26, 2022 11:32
abrams27
requested changes
May 3, 2022
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/TargetKindResolver.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BspProjectMapper.java
Outdated
Show resolved
Hide resolved
|
I tested it manually. I ./install.sh the file first and in bazelbsp.trace.json I ctrl+F and looked for the number of "canCompile": false, then |
abrams27
requested changes
May 3, 2022
...w/src/main/java/org/jetbrains/bsp/bazel/projectview/generator/DefaultProjectViewGenerator.kt
Show resolved
Hide resolved
...va/org/jetbrains/bsp/bazel/projectview/generator/sections/ProjectViewListSectionGenerator.kt
Outdated
Show resolved
Hide resolved
...n/java/org/jetbrains/bsp/bazel/projectview/generator/sections/ProjectViewSectionGenerator.kt
Outdated
Show resolved
Hide resolved
abrams27
approved these changes
May 3, 2022
abrams27
requested changes
May 3, 2022
abrams27
requested changes
May 4, 2022
| @@ -27,3 +27,10 @@ data class ProjectViewBazelPathSection(override val value: Path) : | |||
| const val SECTION_NAME = "bazel_path" | |||
| } | |||
| } | |||
|
|
|||
| data class ProjectViewManualSection(override val value: Boolean) : | |||
There was a problem hiding this comment.
please update the name as well ProjectViewBuildManualTargetsSection
abrams27
requested changes
May 4, 2022
| val javaPath: ProjectViewJavaPathSection?, | ||
| /** bazel flags added to all bazel command invocations */ | ||
| val buildFlags: ProjectViewBuildFlagsSection?, | ||
| /** build manual targets to build, run and test by explicitly asking. */ |
There was a problem hiding this comment.
this flag will be used only for building, for testing / running we will create another one probably.
so it could be flag for building manual targets
| + " bazel path: {}," | ||
| + " debugger address: {}," | ||
| + " java path: {}." | ||
| + "manual targets : {}", |
There was a problem hiding this comment.
+u can add build flags, since i forgot about it
| extends ProjectViewSingletonSectionParser<Boolean, ProjectViewManualTargetsSection> { | ||
|
|
||
| public ProjectViewManualSectionParser() { | ||
| // TODO |
There was a problem hiding this comment.
why TODO, u can use the static name from the section
|
|
||
| private fun combineManualSection(importedProjectViews: List<ProjectView>): ProjectViewManualTargetsSection? = |
There was a problem hiding this comment.
it should be combileBuildManualTargetsSection
abrams27
requested changes
May 6, 2022
| import org.jetbrains.bsp.bazel.projectview.model.ProjectView | ||
| import java.nio.file.Files | ||
| import java.nio.file.Path | ||
|
|
||
| class DefaultProjectViewGenerator : ProjectViewGenerator { | ||
|
|
||
| override fun generatePrettyStringAndSaveInFile(projectView: ProjectView, filePath: Path): Try<Void> = | ||
| writeStringToFile(filePath, generatePrettyString(projectView)) | ||
| writeStringToFile(filePath, generatePrettyString(projectView)) |
There was a problem hiding this comment.
again, could u rollback formatting?
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
added 8 commits
May 6, 2022 13:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added manual tag, when this tag is used build, run and test will not be done without explicitly asked.
https://youtrack.jetbrains.com/issue/BAZEL-40
testing:
manual testing