Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add bazelWorkspaceRootDir flag #276

Merged
merged 19 commits into from Jul 26, 2022
Merged

[feature] Add bazelWorkspaceRootDir flag #276

merged 19 commits into from Jul 26, 2022

Conversation

tpasternak
Copy link
Contributor

@tpasternak tpasternak commented Jul 21, 2022 •
edited by abrams27

@tpasternak tpasternak force-pushed the issue-108-tp branch 3 times, most recently from 7431724 to 106c178 Compare July 22, 2022 09:35
@tpasternak tpasternak changed the title Issue 108 tp [feature] add bazelWorkspaceRootDir flag Jul 22, 2022
@tpasternak tpasternak force-pushed the issue-108-tp branch 3 times, most recently from 867ffe2 to 4a4d574 Compare July 22, 2022 09:47
@tpasternak tpasternak changed the title [feature] add bazelWorkspaceRootDir flag [feature] Add bazelWorkspaceRootDir flag Jul 22, 2022
@tpasternak tpasternak marked this pull request as ready for review July 22, 2022 12:21
@tpasternak tpasternak requested a review from abrams27 July 22, 2022 12:21
@tpasternak
Copy link
Contributor Author

btw, //e2e:BazelBspRemoteJdkTest seems to be flaky

Basak Kapusuzoglu and others added 17 commits July 22, 2022 12:33
@tpasternak
Copy link
Contributor Author

Rebased and force-pushed on current master

@abrams27 abrams27 mentioned this pull request Jul 25, 2022
Closed
abrams27
abrams27 reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

please update the changelog

e2e/testkit.patch Show resolved Hide resolved
install/src/main/java/org/jetbrains/bsp/bazel/install/cli/CliOptionsProvider.kt Outdated Show resolved Hide resolved
abrams27
abrams27 requested changes Jul 26, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tpasternak @abrams27
Update CHANGELOG.md
3115b23 
Co-authored-by: Marcin Abramowicz <44381959+abrams27@users.noreply.github.com>
@tpasternak tpasternak merged commit 5ebe03c into JetBrains:master Jul 26, 2022
@tpasternak tpasternak deleted the issue-108-tp branch July 26, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrams27 abrams27 abrams27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tpasternak @abrams27