[fix] fix transitive target failure check in bloop export #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveniemitz
commented
Aug 15, 2022
server/src/test/java/org/jetbrains/bsp/bazel/server/bloop/BloopExporterTest.kt
Show resolved
Hide resolved
abrams27
approved these changes
Aug 16, 2022
server/src/test/java/org/jetbrains/bsp/bazel/server/bloop/BloopExporterTest.kt
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/bloop/BloopExporter.java
Show resolved
Hide resolved
|
and please update the changelog |
abrams27
changed the title
steveniemitz
changed the title
done! |
abrams27
requested changes
Aug 16, 2022
steveniemitz
force-pushed
the
fix-transitive-target-check
branch
from
50b16d0
to
788f6fc
Compare
abrams27
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#261 accidentally switched the predicate to test if any transitive targets failed, resulting in direct failures causing project imports to fail, and transitive ones to succeed. This is the opposite of what should happen.
This changes it back, and adds a unit test.