[change] add async and sync output processors #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrams27
reviewed
Aug 16, 2022
...er/src/main/java/org/jetbrains/bsp/bazel/server/bsp/managers/BazelBspCompilationManager.java
Show resolved
Hide resolved
steveniemitz
force-pushed
the
fix-async-output
branch
from
f760f6e
to
4b08957
Compare
steveniemitz
force-pushed
the
fix-async-output
branch
from
4b08957
to
deda6bb
Compare
tpasternak
reviewed
Aug 30, 2022
bazelrunner/src/main/java/org/jetbrains/bsp/bazel/bazelrunner/BazelProcess.kt
Show resolved
Hide resolved
abrams27
approved these changes
Aug 30, 2022
|
is this good to land? I'm going to follow up with another review that uses BEP to get the workspace and execution roots, which will let us remove the sync version completely. |
|
yea, sorry i forgot about this PR |
abrams27
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#279 re-introduced a bug on linux where the OutputProcessor can hang for up to 45 seconds waiting for the process (which has already existed) to exit.
This change adds a different type of OutputProcessor for commands that need to wait (bazel info, etc) to receive the full output, vs ones that don't (piping the build logs to the output handlers).