New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[change] pass originId into server responses #289
Conversation
60f5330
to
0755b37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure about passing the origin id to the project storage, but it seems useful since we are logging there as well - @lukaszwawrzyk what do u think?
bazelrunner/src/main/java/org/jetbrains/bsp/bazel/bazelrunner/BazelProcess.kt
Outdated
Show resolved
Hide resolved
bazelrunner/src/main/java/org/jetbrains/bsp/bazel/bazelrunner/BazelRunnerBuilder.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/ProjectSyncService.java
Outdated
Show resolved
Hide resolved
We are loging it because automagic error reporting is broken in IntelliJ duriing build, but not during sync. Maybe new bsp plugin could fix that. Maybe we can keep ProjectStorage as it was before. The api is confusing now, Initially I though that project is cached by origin id now or something and it is just error logging.
Sadly it breaks the original scala plugin with bsp support as its build console doesn't support colors :/ To solve this we might check who is our bsp client, and if it is the new plugin we can color the output. Another thing. There is a lot of context passing (originId) that makes it harder to see what is important. It should be possible to refactor. Not sure if it can be perfect, but some places would be more clean. |
935a6cc
to
e82c2a2
Compare
e82c2a2
to
54efd27
Compare
Additionally I added
BazelFlag.color(true)
for building target (useful inintellij-bsp
plugin).