Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] send notifications to client while junit5 testing #299

Merged
merged 5 commits into from Oct 5, 2022
Merged

[feature] send notifications to client while junit5 testing #299

merged 5 commits into from Oct 5, 2022

Conversation

BlackAnubis7
Copy link
Contributor

bazel-bsp server now notifies the BSP client about events happening during testing with JUnit, including single tests and their results, as well as their hierarchy in test suites

Co-authored-by: azdrojowa123 aleksandra.zdrojowa@jetbrains.com

@BlackAnubis7 BlackAnubis7 mentioned this pull request Sep 26, 2022
Merged
abrams27
abrams27 requested changes Sep 29, 2022
View reviewed changes
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill take a look one more time tomorrow

logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt Outdated Show resolved Hide resolved
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt Outdated Show resolved Hide resolved
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt Outdated Show resolved Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt Outdated Show resolved Hide resolved
server/src/test/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParserTest.kt Outdated Show resolved Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt Outdated Show resolved Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt Outdated Show resolved Hide resolved
@abrams27 abrams27 changed the title [feature] send notifications to client while junit testing [feature] send notifications to client while junit5 testing Oct 3, 2022
abrams27
abrams27 requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just nitpicking + please update the changelog

server/src/main/java/org/jetbrains/bsp/bazel/server/sync/ExecuteService.kt Outdated Show resolved Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt Outdated Show resolved Hide resolved
logger/src/main/java/org/jetbrains/bsp/bazel/logger/BspClientTestNotifier.kt Outdated Show resolved Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/JUnitTestParser.kt Outdated Show resolved Hide resolved
@abrams27 abrams27 mentioned this pull request Oct 4, 2022
Closed
abrams27
abrams27 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lets gooo

@abrams27 abrams27 merged commit 7fcf9c0 into JetBrains:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszwawrzyk lukaszwawrzyk lukaszwawrzyk approved these changes

@abrams27 abrams27 abrams27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BlackAnubis7 @lukaszwawrzyk @abrams27