[fix] postpone bazel info #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpasternak
force-pushed
the
postpone-baze-info-run
branch
3 times, most recently
from
b63ffdc
to
732437e
Compare
Before this change, `bazel info` was called before the actual BSP server. This means, there was no clear way to submit failure (for example if `bazel` executable was not available in PATH). Currently, it is run on `build/intitialize` request, so the error will be logged via BSP failure response.
tpasternak
force-pushed
the
postpone-baze-info-run
branch
from
732437e
to
51eff29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
bazel infowas called before the actual BSPserver. This means, there was no clear way to submit failure (for
example if
bazelexecutable was not available in PATH). Currently,it is run on
build/intitializerequest, so the error will be loggedvia BSP failure response.