[fix] handle java packages that does not match directory structure #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrams27
reviewed
Dec 21, 2022
tpasternak
force-pushed
the
handle-package-and-directory-mismatch
branch
3 times, most recently
from
bc67bde
to
31ab5a2
Compare
Previously, the `calculateJVMSourceRoot` function was falling back to parent of the `source` path only in case the package name was longer than the directory hierarchy. But in case the package mismatched the directory structure, but if it was shorter than directory hierarchy length, it returned incorrect value.
tpasternak
force-pushed
the
handle-package-and-directory-mismatch
branch
2 times, most recently
from
8734027
to
a412840
Compare
abrams27
approved these changes
Dec 21, 2022
abrams27
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
calculateJVMSourceRootfunction was falling back to parent of thesourcepath only in case the package name was longer than the directory hierarchy. But in case the package mismatched the directory structure, but if it was shorter than directory hierarchy length, it returned incorrect value.