Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add class jars generated during annotation processing #372

Conversation

tpasternak
Copy link
Contributor

It would also be possible to pass source jars, but there's no clear way how it should be handled in BSP

https://bazel.build/rules/lib/JavaInfo#JavaInfo

@tpasternak tpasternak marked this pull request as ready for review April 5, 2023 12:41
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont forget to update the changelog

It would also be possible to pass source jars, but there's no clear way
how it should be handled in BSP

https://bazel.build/rules/lib/JavaInfo#JavaInfo
@tpasternak tpasternak force-pushed the tpasternak/add-binary-jars-to-classpath branch from cf18c8a to 93d95cb Compare April 5, 2023 15:09
@tpasternak
Copy link
Contributor Author

Done

@tpasternak tpasternak merged commit 89b0ae0 into JetBrains:master Apr 5, 2023
15 checks passed
@tpasternak tpasternak deleted the tpasternak/add-binary-jars-to-classpath branch April 5, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants