Redo: set until-build to undefined value #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we unset until-build in DSL. However, Intellij SDK Gradle plugin DSL does not support setting only since-build, while omitting until-build. So we effectively made the plugin compatible with a single version of Intellij. This change fixes that by disabling patching since-build/until-build from DSL and setting since-build version directly in plugin.xml
dima-avdeev-jb
approved these changes
Jan 23, 2023
eymar
pushed a commit
that referenced
this pull request
Jan 24, 2023
Previously we unset until-build in DSL. However, Intellij SDK Gradle plugin DSL does not support setting only since-build, while omitting until-build. So we effectively made the plugin compatible with a single version of Intellij. This change fixes that by disabling patching since-build/until-build from DSL and setting since-build version directly in plugin.xml (cherry picked from commit 08c93ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we unset until-build in DSL.
However, Intellij SDK Gradle plugin DSL
does not support setting only since-build,
while omitting until-build.
So we effectively made the plugin
compatible with a single version of Intellij.
This change fixes that by disabling patching
since-build/until-build from DSL and setting
since-build version directly in plugin.xml