Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo: set until-build to undefined value #2658

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Redo: set until-build to undefined value #2658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions idea-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ intellij {
type.set(projectProperties.platformType)
version.set(projectProperties.platformVersion)
downloadSources.set(projectProperties.platformDownloadSources)
updateSinceUntilBuild.set(false)

plugins.set(
listOf(
Expand Down Expand Up @@ -55,10 +56,6 @@ tasks {
channels.set(projectProperties.pluginChannels)
}

patchPluginXml {
sinceBuild.set(projectProperties.pluginSinceBuild)
}

runPluginVerifier {
ideVersions.set(projectProperties.pluginVerifierIdeVersions)
}
Expand All @@ -70,7 +67,6 @@ class ProjectProperties(private val project: Project) {
val platformVersion get() = stringProperty("platform.version")
val platformDownloadSources get() = stringProperty("platform.download.sources").toBoolean()
val pluginChannels get() = listProperty("plugin.channels")
val pluginSinceBuild get() = stringProperty("plugin.since.build")
val pluginVerifierIdeVersions get() = listProperty("plugin.verifier.ide.versions")

private fun stringProperty(key: String): String =
Expand Down
4 changes: 2 additions & 2 deletions idea-plugin/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ kotlin.stdlib.default.dependency=false
deploy.version=0.1-SNAPSHOT

plugin.channels=snapshots
plugin.since.build=213
## See https://jb.gg/intellij-platform-builds-list for available build versions.
# Intellij since-build should be updated directly in src/main/resources/META-INF/plugin.xml
# See https://jb.gg/intellij-platform-builds-list for available build versions.
plugin.verifier.ide.versions=2021.3, 2022.1, 2022.2

platform.type=IC
Expand Down
3 changes: 3 additions & 0 deletions idea-plugin/src/main/resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@

</description>

<!-- until-build is omitted, so we don't have to update it after each Intellij release -->
<idea-version since-build="213"/>

<!-- Product and plugin compatibility requirements -->
<!-- https://plugins.jetbrains.com/docs/intellij/plugin-compatibility.html -->
<depends>com.intellij.modules.platform</depends>
Expand Down