Fix the pointer icon in SelectionContainer #1014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last big merge from upstream we accidentally removed the
pointerHoverIcon
fromSelectionRegistrar.makeSelectionModifier
. But we also gained a mechanism to define the pointer icon from upstream. It didn't, however, specify a pointer icon for any platforms other than Android.Proposed Changes
textPointerIcon
toPointerIcon.Text
on all platforms. This can have addition effects, as it's also used inModifier.defaultTextFieldPointer
andModifier.cupertinoTextFieldPointer
.Testing
Test: Added a unit test.