Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pointer icon in SelectionContainer #1014

Merged
merged 1 commit into from Jan 24, 2024

Conversation

m-sasha
Copy link

@m-sasha m-sasha commented Jan 23, 2024

In the last big merge from upstream we accidentally removed the pointerHoverIcon from SelectionRegistrar.makeSelectionModifier. But we also gained a mechanism to define the pointer icon from upstream. It didn't, however, specify a pointer icon for any platforms other than Android.

Proposed Changes

  • Fix the pointer icon in SelectionContainer by implementing Modifier.textPointerHoverIcon to return pointerHoverIcon(textPointerIcon) on all platforms.
  • Set textPointerIcon to PointerIcon.Text on all platforms. This can have addition effects, as it's also used in Modifier.defaultTextFieldPointer and Modifier.cupertinoTextFieldPointer.

Testing

Test: Added a unit test.

…extPointerHoverIcon to return pointerHoverIcon(textPointerIcon) on all platforms.
@m-sasha
Copy link
Author

m-sasha commented Jan 23, 2024

Added @eymar and @mazunin-v-jb as reviewers because it affects wasmJs and ios platforms.

@m-sasha m-sasha merged commit db202d9 into jb-main Jan 24, 2024
6 checks passed
@m-sasha m-sasha deleted the m-sasha/fix-SelectionContainer-pointerHoverIcon branch January 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants