forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility stage 1 #1025
Merged
Merged
Accessibility stage 1 #1025
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
c1d2962
Update copyright, add CMPAccessibilityScrollView
elijah-semyonov 0a150aa
Rewire ScrollView accessibility implementation
elijah-semyonov 9c32cb8
Avoid edge case where impl could be changed after the object is logic…
elijah-semyonov 1125119
Add scrolling logic stubs
elijah-semyonov 6c6cf0a
Add @ExportoOjc for name resolution in debugger
elijah-semyonov 3729153
Print debug data on focus
elijah-semyonov 49e669b
Fix crash
elijah-semyonov 1164c62
Add logic for scrolling.
elijah-semyonov 868d512
Add TODOs
elijah-semyonov 5b12a6d
Add TODO
elijah-semyonov 1fcef2a
Fix
elijah-semyonov e5de324
Add TODOs, remove dead code
elijah-semyonov 8959b17
Add testTag and recursive scroll call
elijah-semyonov e8b601e
Fix scrolling
elijah-semyonov 599e68c
Remove indirect implementation.
elijah-semyonov 7dcf650
Add EditableText to label
elijah-semyonov e572daf
Add more debug logs.
elijah-semyonov 9d89068
Add more debug logs.
elijah-semyonov 0f40513
Post layout change notification when synced something.
elijah-semyonov 364a0df
Add todo for crash.
elijah-semyonov d257c17
Minor changes
elijah-semyonov 937ecaf
Enrich logging
elijah-semyonov 712a7b6
Add scroll to visible element on focus change
elijah-semyonov a90575f
Add arbitary scale to avoid overscrolling
elijah-semyonov 0c6f2c1
Fix scrollTo logic a bit
elijah-semyonov 9312951
Fix scrollTo logic a bit
elijah-semyonov f651d43
Add TODO
elijah-semyonov 47ece12
Add TODO
elijah-semyonov 2dea87e
Avoid creating a new semantics node every time its id is asked
elijah-semyonov 768448c
Add possibility to refocus a11y from dead elements
elijah-semyonov afd3d83
Eagerly recompute semantics tree on render
elijah-semyonov b617f2e
Revert "Eagerly recompute semantics tree on render"
elijah-semyonov e16af45
Cherry pick minor refactoring from reverted commit
elijah-semyonov cc89a29
Revert "Prevent unattached nodes from making it into the semantics tree"
elijah-semyonov 3dc016d
Remove unrelevant todo
elijah-semyonov a7e4eed
Add config option to force accessibility sync
elijah-semyonov 81faf63
Integrate new strategy with some debug prints.
elijah-semyonov a763f9c
Add debug log
elijah-semyonov a8f9f8c
Remove ghost semantic nodes.
elijah-semyonov 1c1a707
Comment out error for now
elijah-semyonov 0b3b0f1
Fix compilation error and `accessibilityActivate` crash
elijah-semyonov 9f5dc1f
Resolve label on the fly
elijah-semyonov d8ddae7
Resolve isAccessible dynamically
elijah-semyonov 44bb9b7
Modify isAccessibilityElement logic
elijah-semyonov bd63d31
Ignore IsTraversalGroup for accessibility focus
elijah-semyonov 4a50229
Modify accessibility logic
elijah-semyonov fbc81f9
Compute UITraits lazily
elijah-semyonov 8b4a809
Modify label computation logic
elijah-semyonov 9b70ebb
Move more computed properties to lazy
elijah-semyonov b056e08
Make all a11y properties computed
elijah-semyonov 0c57f01
Add todo
elijah-semyonov 88c9217
Update API
elijah-semyonov c1985a7
Fix unconditional log
elijah-semyonov 8013201
Mark experimental API
elijah-semyonov 8634379
OptIn and remove feature flag.
elijah-semyonov f6409e6
Fix invalid cardinality
elijah-semyonov 2c511c1
Revert cherrypick
elijah-semyonov 99274b8
Merge branch 'jb-main' into es/accessibility-stage-1
elijah-semyonov e8cc3c3
Remove redundant TODO
elijah-semyonov 87da0d3
Merge branch 'jb-main' into es/accessibility-stage-1
elijah-semyonov 592cd1e
Remove extra return.
elijah-semyonov 816c358
Add review-based changes
elijah-semyonov 6a9f2e7
Remove println
elijah-semyonov caca45a
Add debug logger to demo app
elijah-semyonov 0efb15d
Fix scrolling bug
elijah-semyonov File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...se/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPAccessibilityContainer.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...se/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPAccessibilityContainer.m
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPMacros.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPUIKitUtils.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPViewController.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtilsTests/CMPUIKitUtilsTests-Bridging-Header.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtilsTests/CMPViewControllerTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtilsTests/Utils/MockAppDelegate.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...se/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtilsTests/Utils/XCTestCase.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we can update to 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, @MatkovIvan said that Google stated that those indicate the file creation date and not the current one