Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS modify lifecycle and containment #1027

Merged
merged 6 commits into from Jan 30, 2024
Merged

Conversation

elijah-semyonov
Copy link

@elijah-semyonov elijah-semyonov commented Jan 30, 2024

Proposed Changes

Define state of being alive for CMPViewController as an interval from the first viewWillAppear until a moment where following criteria is met:

  1. Not rootViewController of any connected scene UIWindow.
  2. Not transitively or directly contained by any UIViewController passing (1), via either parent<->child or presenting<->presented chain.

Testing

Test: CMPViewControllerTests.swift in CMPUIKitUtils, ProperContainmentDisposal in ComposeDemo.

Issues Fixed

Fixes: JetBrains/compose-multiplatform#4188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants