Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass PointerEventType to ComposeSceneLayer.onOutsidePointerEvent #1057

Merged
merged 1 commit into from Feb 6, 2024

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

  • Changes internal API of ComposeSceneLayer
  • Dismiss Popups only on Press event type
  • iOS platform binding will be fixed in the next PR by @dima-avdeev-jb

Testing

Test: Run reproduction snipped from the issue

Issues Fixed

Fixes JetBrains/compose-multiplatform#4080

@MatkovIvan MatkovIvan merged commit 64c8cff into jb-main Feb 6, 2024
4 of 5 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-popup-double-dismiss branch February 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants