Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support software keyboard inset in Dialog #1067

Merged
merged 3 commits into from Feb 16, 2024
Merged

Support software keyboard inset in Dialog #1067

merged 3 commits into from Feb 16, 2024

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

  • Add a way to include software keyboard height into Dialog centering calculation.
  • Add DialogProperties.useSoftwareKeyboardInset option to disable this behavior.
  • Align default behavior with Android (software keyboard affects Dialog)

Known issues

  • Animation lags with platformLayers = true on iOS

Testing

Test: run mpp, DialogWithTextField page

useSoftwareKeyboardInset = true useSoftwareKeyboardInset = false
Simulator Screenshot - iPhone 15 Pro - 2024-02-07 at 16 09 07 Simulator Screenshot - iPhone 15 Pro - 2024-02-07 at 16 29 56

Issues Fixed

Fixes JetBrains/compose-multiplatform#4210

@igordmn igordmn removed their request for review February 9, 2024 22:28
@elijah-semyonov elijah-semyonov mentioned this pull request Feb 13, 2024
Draft
@igordmn igordmn self-requested a review February 14, 2024 09:26
@MatkovIvan MatkovIvan merged commit 3159e7e into jb-main Feb 16, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/dialog-ime-inset branch February 16, 2024 19:08
@pcorreia89
Copy link

Hi, I am still having this issue with compose version 1.6.0-rc03. Anyone else?

I am using BasicAlertDialog component as shown below.

Screenshot 2024-02-27 at 10 08 14 pm

WhatsApp Image 2024-02-27 at 22 02 25

@MatkovIvan
Copy link
Member Author

@pcorreia89 it won't be included in 1.6.0 because it introduces a new public API after a feature freeze for this release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

@dima-avdeev-jb dima-avdeev-jb dima-avdeev-jb approved these changes

Assignees
No one assigned
Labels
changes in API
Projects
None yet
Milestone
No milestone
4 participants
@MatkovIvan @pcorreia89 @igordmn @dima-avdeev-jb