Fix sharing composition locals with new platform layers #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-avdeev-jb
approved these changes
Feb 8, 2024
MatkovIvan
commented
Feb 8, 2024
| @@ -159,6 +171,7 @@ internal fun rememberComposeSceneLayer( | |||
| val density = LocalDensity.current | |||
| val layoutDirection = LocalLayoutDirection.current | |||
| val parentComposition = rememberCompositionContext() | |||
| val compositionLocalContext by rememberUpdatedState(currentCompositionLocalContext) | |||
There was a problem hiding this comment.
It's already contained inside parentComposition that we already passing, but it's internal to runtime, so we cannot receive it from there.
At the same time, we must create a new composition for layers since it has different scope/invalidations/etc
So for now we have to pass it separately 😞
igordmn
approved these changes
Feb 8, 2024
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/MultiLayerComposeScene.skiko.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
CompositionLocalContextto all layersTesting
Test: unit tests currently runs without platform layers, so existing tests didn't find this issue (TODO). Added a separate page to mpp demo for manual testing for now.
Issues Fixed
Fixes JetBrains/compose-multiplatform#4281