fix issue with screen size #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
requested changes
Feb 10, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Feb 12, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Show resolved
Hide resolved
MatkovIvan
approved these changes
Feb 12, 2024
dima-avdeev-jb
deleted the
dima.avdeev/ios-fix-scene-size-after-present-native-view-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Now size and point in
boundsInWindowcalculates separatelly.Previously:
Screen.Recording.2024-02-11.at.02.52.10.mp4
As you can see Compose have smaller size while on background. And that's why previously it's window bounds was smaller, than Compose opens fully.
In this PR:
Screen.Recording.2024-02-11.at.22.36.31.mov
Testing
in demo Demo App navigate to screen
Native modal with navigation, press present popup, and swipe application to background. Then open application again and close native popup by draggin from to to bottom. Compose size should be correct.Issues Fixed
Fixes: https://youtrack.jetbrains.com/issue/COMPOSE-902/iOS-scene-size-after-sending-the-app-to-background-or-changing-orientation-with-open-modal