Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closing scene during scroll animation #1096

Merged
merged 2 commits into from Feb 12, 2024
Merged

Fix closing scene during scroll animation #1096

merged 2 commits into from Feb 12, 2024

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

Testing

Test: run a new unit test

igordmn
igordmn approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we also have a public issue, please add it to the description

@MatkovIvan MatkovIvan merged commit 9267e3a into jb-main Feb 12, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-scene-cancel-during-scroll branch February 12, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-sasha m-sasha m-sasha approved these changes

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
changes in common
Projects
None yet
Milestone
No milestone
3 participants
@MatkovIvan @m-sasha @igordmn