Trigger fling callbacks on mouse wheel scroll #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-semyonov
approved these changes
Feb 14, 2024
igordmn
approved these changes
Feb 14, 2024
MatkovIvan
force-pushed
the
ivan.matkov/fix-mouse-fling
branch
from
bc4abb0
to
c563074
Compare
igordmn
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
onScrollStoppedcallback after mouse wheel scrollScrollableDefaultFlingBehaviors during mouse scroll to avoid breaking changesdispatchRawDelta,isSmoothScrollingEnabled = falsewill just disable animation insteadTesting
Test: run pager page in mpp demo
Issues Fixed
Fixes JetBrains/compose-multiplatform#3447
Fixes JetBrains/compose-multiplatform#3454