Consume less CPU for text field cursor blinking #1113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
force-pushed
the
m-sasha/textfield-caret-performance
branch
from
eacc9a9
to
72a23a9
Compare
igordmn
approved these changes
Feb 20, 2024
|
Done |
m-sasha
force-pushed
the
m-sasha/textfield-caret-performance
branch
from
72a23a9
to
bd3da25
Compare
m-sasha
added
the
changelog1.6.1
m-sasha
changed the title
delay) to implement text field cursor blinkingdelay) to implement it
m-sasha
changed the title
delay) to implement it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by using pure coroutines (
delay) to implement it. Running it as an animation unnecessarily consumes CPU time.Proposed Changes
runCursorAnimationthat cancels it for tests.SkikoComposeUiTestto close the scene before callingtestScope.runTest {}, so that the Compose coroutines are cancelled, and the test doesn't hang.Testing
Test: Added tests to verify that they don't hang.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4225