Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix iOS SelectionHandles crash on scrollable SelectionContainer #1121

Merged
merged 2 commits into from Feb 19, 2024
Merged

fix iOS SelectionHandles crash on scrollable SelectionContainer #1121

merged 2 commits into from Feb 19, 2024

Conversation

dima-avdeev-jb
Copy link

Proposed Changes

  • Update code in iOS SelectionHandles position calculation like in Android was.

Testing

Run by hands sample in DemoApp / Components / Selection /

Issues Fixed

MatkovIvan
MatkovIvan approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-19 at 17 51 17

It's still not ideal and requires future polishing. But we need it as a fix of the crash introduced by merging 1.6.0

@MatkovIvan MatkovIvan merged commit 246b0bb into jb-main Feb 19, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-ios-handles branch February 19, 2024 17:49
igordmn pushed a commit that referenced this pull request Feb 19, 2024
@dima-avdeev-jb @igordmn
fix iOS SelectionHandles crash on scrollable SelectionContainer (#1121)
a3e3eea 
## Proposed Changes

- Update code in iOS SelectionHandles position calculation like in
Android was.

## Testing

Run by hands sample in DemoApp / Components / Selection /

## Issues Fixed

 - JetBrains/compose-multiplatform#4323

---------

Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
# Conflicts:
#	compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/components/Selection.kt
@igordmn igordmn added changelog: prerelease fix Fixes the bug introduced in alpha/beta/rc ios labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan approved these changes

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
changelog: prerelease fix Fixes the bug introduced in alpha/beta/rc ios
Projects
None yet
Milestone
No milestone
3 participants
@dima-avdeev-jb @MatkovIvan @igordmn