Fix additional windows creation with COMPONENT layer type
#1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Feb 21, 2024
MatkovIvan
deleted the
ivan.matkov/ignore-component-layertype-for-window
branch
igordmn
pushed a commit
that referenced
this pull request
Mar 4, 2024
## Proposed Changes - Ignore `LayerType.OnComponent` in `ComposeWindowPanel` instead of crash-check because it might be triggered for creating second window/dialog from `ComposePanel` with enabled offscreen rendering and component layers type ## Testing Test: try to create a new window via composable function from `ComposePanel` with `LayerType.OnComponent`
MatkovIvan
changed the title
LayerType.OnComponent in ComposeWindowPanelCOMPONENT layer type
MatkovIvan
added
the
changelog1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
LayerType.OnComponentinComposeWindowPanelinstead of crash-check because it might be triggered for creating second window/dialog fromComposePanelwith enabled offscreen rendering and component layers typeTesting
Test: try to create a new window via composable function from
ComposePanelwithLayerType.OnComponent