Fix Material3 slider getting stuck while dragging #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its value changes in the middle of dragging the slider.
m-sasha
force-pushed
the
m-sasha/slider-fix
branch
from
891894a
to
8233484
Compare
MatkovIvan
approved these changes
Feb 26, 2024
igordmn
approved these changes
Feb 26, 2024
igordmn
pushed a commit
that referenced
this pull request
Mar 4, 2024
…create `SliderState` when it changes (#1135)
m-sasha
added
the
changelog1.6.1
m-sasha
changed the title
onValueChangeFinished rather than recreate SliderState when it changesSliderState when onValueChangeFinished changes
m-sasha
changed the title
SliderState when onValueChangeFinished changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...due to recreation of
SliderStatewhenonValueChangeFinishedchangesProposed Changes
SliderState.onValueChangeFinishedto bevarwithinternal set.Slider, removeonValueChangeFinishedfrom the list of keys used when rememberingSlideState.SliderState.onValueChangeFinishedwhenever theonValueChangeFinishedargument changes.Testing
Test: Added a unit test.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4366