Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep adding interop order consistent between platforms #1143

Merged
merged 1 commit into from Feb 27, 2024

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Feb 26, 2024

Proposed Changes

  • Inserting interop views in the reverse order to get direct order rendering. It's a hotfix to restore 1.5.x behaviour, the right order should rely on rendering, not adding order in the future.

Testing

Test: run repruduction from the issue or "nasa" demo from this commit MatkovIvan@6a3663d (not in the main repo because it requires manually added jar)

Issues Fixed

Fixes JetBrains/compose-multiplatform#1521 (comment)

@MatkovIvan MatkovIvan merged commit 71947f6 into jb-main Feb 27, 2024
5 of 6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/keep-interop-in-reverse-order branch February 27, 2024 12:59
igordmn pushed a commit that referenced this pull request Mar 4, 2024
## Proposed Changes

- Inserting interop views in the reverse order to get direct order
rendering. It's a hotfix to restore [1.5.x
behaviour](https://github.com/JetBrains/compose-multiplatform-core/blob/v1.5.12/compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeWindowDelegate.desktop.kt#L77),
the right order should rely on _rendering_, not adding order in the
future.

## Testing

Test: run repruduction from the issue or "nasa" demo from this commit
MatkovIvan@6a3663d
(not in the main repo because it requires manually added jar)

## Issues Fixed

Fixes
JetBrains/compose-multiplatform#1521 (comment)
@MatkovIvan MatkovIvan added the changelog1.6.1 Temporary label for 1.6.1 changelog (will be removed) label Mar 11, 2024
@igordmn igordmn changed the title Keep adding interop order consistent betwen platforms Keep adding interop order consistent betwуen platforms Mar 14, 2024
@igordmn igordmn changed the title Keep adding interop order consistent betwуen platforms Keep adding interop order consistent between platforms Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog1.6.1 Temporary label for 1.6.1 changelog (will be removed)
Projects
None yet
2 participants