Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when selecting a character before the punctuation sign #1151

Merged
merged 4 commits into from Feb 29, 2024

Conversation

elijah-semyonov
Copy link

@elijah-semyonov elijah-semyonov commented Feb 29, 2024

Proposed Changes

Fix OutOfBounds logical error leading to crash. Refactor testing of caret placement to be more apparent.

Testing

Test: CupertinoTextFieldDelegateTest.determineCursorDesiredOffset_tap_before_punctuation

Issues Fixed

Fixes: JetBrains/compose-multiplatform#4388, crash in JetBrains/compose-multiplatform#4353

Note

This PR fixes the crash, the behavior is still incorrect. Consult with code owner @mazunin-v-jb.

@elijah-semyonov elijah-semyonov merged commit 8407410 into jb-main Feb 29, 2024
6 checks passed
@elijah-semyonov elijah-semyonov deleted the es/4388-fix branch February 29, 2024 12:19
igordmn pushed a commit that referenced this pull request Mar 4, 2024
## Proposed Changes

Fix OutOfBounds logical error leading to crash. Refactor testing of
caret placement to be more apparent.

## Testing

Test:
CupertinoTextFieldDelegateTest.determineCursorDesiredOffset_tap_before_punctuation

## Issues Fixed

Fixes: JetBrains/compose-multiplatform#4388

## Note
This PR fixes the crash, the behavior is still incorrect. Consult with
code owner @mazunin-v-jb.
@elijah-semyonov elijah-semyonov added the changelog1.6.1 Temporary label for 1.6.1 changelog (will be removed) label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog1.6.1 Temporary label for 1.6.1 changelog (will be removed)
Projects
None yet
3 participants