Fix unintended state reset on iOS #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
requested changes
Feb 29, 2024
MatkovIvan
approved these changes
Feb 29, 2024
igordmn
reviewed
Feb 29, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeContainer.uikit.kt
Outdated
Show resolved
Hide resolved
igordmn
approved these changes
Mar 1, 2024
igordmn
pushed a commit
that referenced
this pull request
Mar 4, 2024
## Proposed Changes Perform `setContent` only once per ComposeContainer mediator lifetime. ## Testing Test: scenario described in [the comment](JetBrains/compose-multiplatform#3698 (comment)) doesn't cause whole app recomposition with remembered state recreation ## Issues Fixed Fixes: JetBrains/compose-multiplatform#3698 (comment)
elijah-semyonov
added
the
changelog1.6.1
elijah-semyonov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Perform
setContentonly once per ComposeContainer mediator lifetime.Testing
Test: scenario described in the comment doesn't cause whole app recomposition with remembered state recreation
Issues Fixed
Fixes: JetBrains/compose-multiplatform#3698 (comment)