Fix ExposedDropdownMenuBox recomposing unnecessarily #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Mar 1, 2024
...rial3/material3/src/skikoMain/kotlin/androidx/compose/material3/ExposedDropdownMenu.skiko.kt
Show resolved
Hide resolved
MatkovIvan
approved these changes
Mar 4, 2024
igordmn
approved these changes
Mar 4, 2024
igordmn
pushed a commit
that referenced
this pull request
Mar 4, 2024
m-sasha
added
the
changelog1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ExposedDropdownMenuBox will recompose whenever its bounds change.
This has already been fixed in Android, but we haven't integrated the changes.
Proposed Changes
skikoTest.Testing
Test: Added new EDM tests from Android.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4364