Fix a logical error causing Compose tree corruption and consequent crash on iOS #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
requested changes
Mar 5, 2024
eymar
reviewed
Mar 5, 2024
compose/ui/ui/src/jsNativeMain/kotlin/androidx/compose/ui/node/SortedSet.jsNative.kt
Show resolved
Hide resolved
Added a unit test. |
MatkovIvan
approved these changes
Mar 5, 2024
m-sasha
approved these changes
Mar 5, 2024
igordmn
pushed a commit
that referenced
this pull request
Mar 5, 2024
## Proposed Changes Add reduced reported issue repro, fix logical error in `SortedSet.add`. ## Testing Test: `SortedSetTest.checkExistingWhenAdded`, no crash happens in reported scenario. ## Issues Fixed Fixes: JetBrains/compose-multiplatform#4422 # Conflicts: # compose/mpp/demo/src/uikitMain/kotlin/bugs/IosBugs.kt
elijah-semyonov
added
the
changelog1.6.1
elijah-semyonov
changed the title
elijah-semyonov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add reduced reported issue repro, fix logical error in
SortedSet.add.Testing
Test:
SortedSetTest.checkExistingWhenAdded, no crash happens in reported scenario.Issues Fixed
Fixes: JetBrains/compose-multiplatform#4422