Fix keyboard opening when scrolling begins within a TextField #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazunin-v-jb
approved these changes
Mar 11, 2024
igordmn
requested changes
Mar 11, 2024
...ation/src/skikoMain/kotlin/androidx/compose/foundation/gestures/TapGesturesDetector.skiko.kt
Outdated
Show resolved
Hide resolved
...ation/src/skikoMain/kotlin/androidx/compose/foundation/gestures/TapGesturesDetector.skiko.kt
Outdated
Show resolved
Hide resolved
ASalavei
changed the title
|
PR was closed. Is it by intention? |
…ion-until-successfull-touch-release
|
@igordmn , yes, I found a critical bug. I will be working on fix. |
…ion-until-successfull-touch-release
…ion-until-successfull-touch-release
ASalavei
changed the title
|
@igordmn , the bug was fixed. Please take a look. |
mazunin-v-jb
approved these changes
Apr 5, 2024
igordmn
approved these changes
Apr 12, 2024
ASalavei
deleted the
andrei.salavei/postpone-test-field-selection-until-successfull-touch-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Handle touch up gesture to focus on TextField. The gesture allows the containing node to cancel the interaction if necessary.
Issue fixed: JetBrains/compose-multiplatform#4204