Fix iOS TextField crash when using speech-to-text #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mazunin-v-jb we found a bug in characters range calculation. Also fixed in current PR. |
MatkovIvan
approved these changes
Mar 12, 2024
mazunin-v-jb
approved these changes
Mar 12, 2024
ASalavei
added a commit
that referenced
this pull request
Mar 12, 2024
## Proposed Changes Use iOS native implementation of `UITextInputTokenizerProtocol` represented by the class `UITextInputStringTokenizer`. The PR reverts changes of #808 , however due to `textInput = this` parameter, the Fast Delete feature keeps working as intended. Fixes: JetBrains/compose-multiplatform#4443
ASalavei
changed the title
ASalavei
added
the
changelog1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use iOS native implementation of
UITextInputTokenizerProtocolrepresented by the classUITextInputStringTokenizer.The PR reverts changes of #808 , however due to
textInput = thisparameter, the Fast Delete feature keeps working as intended.Fixes: JetBrains/compose-multiplatform#4443