Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow drawing outside of platform layers #1190

Merged
merged 21 commits into from Mar 22, 2024
Merged

Allow drawing outside of platform layers #1190

merged 21 commits into from Mar 22, 2024

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

Testing

Test: Try to use new platform layers with shadows

image

Issues Fixed

Fixes: JetBrains/compose-multiplatform#4460

@MatkovIvan MatkovIvan added the changelog: highlight Highlight PR to the changelog label Mar 13, 2024
elijah-semyonov
elijah-semyonov approved these changes Mar 13, 2024
View reviewed changes
Copy link

@elijah-semyonov elijah-semyonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m-sasha
m-sasha reviewed Mar 13, 2024
View reviewed changes
Copy link

@m-sasha m-sasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to run before finishing review; submitted what I already had.

compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/AwtEventFilter.desktop.kt Outdated Show resolved Hide resolved
...ose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/SwingComposeSceneLayer.desktop.kt Outdated Show resolved Hide resolved
...e/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/DesktopComposeSceneLayer.desktop.kt Outdated Show resolved Hide resolved
@MatkovIvan
Merge branch 'jb-main' into ivan.matkov/fix-crop-layers
97179b4 
# Conflicts:
#	compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/DesktopComposeSceneLayer.desktop.kt
#	compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/SwingComposeSceneLayer.desktop.kt
#	compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/WindowComposeSceneLayer.desktop.kt
@MatkovIvan
Address feedback
b3ee86d
@m-sasha m-sasha self-requested a review March 14, 2024 15:34
@igordmn igordmn mentioned this pull request Mar 19, 2024
Open
@MatkovIvan
Merge branch 'jb-main' into ivan.matkov/fix-crop-layers
77533dd 
# Conflicts:
#	compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeContainer.uikit.kt
@MatkovIvan
Add TODOs about known issues
b9869df
@MatkovIvan MatkovIvan merged commit e2b48aa into jb-main Mar 22, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-crop-layers branch March 22, 2024 11:47
@MatkovIvan MatkovIvan restored the ivan.matkov/fix-crop-layers branch April 18, 2024 13:55
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-crop-layers branch April 18, 2024 13:56
@MatkovIvan MatkovIvan mentioned this pull request Apr 18, 2024
Merged
MatkovIvan added a commit that referenced this pull request Apr 18, 2024
@MatkovIvan
Revert "Do not measure clipped graphics" (#1285)
58dbfc0 
This reverts commit ac6cd20. It was
incorrect last-minute optimization in #1190

## Testing

Test: See #1190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-sasha m-sasha m-sasha approved these changes

@elijah-semyonov elijah-semyonov elijah-semyonov approved these changes

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
changelog: highlight Highlight PR to the changelog
Projects
None yet
Milestone
No milestone
4 participants
@MatkovIvan @elijah-semyonov @m-sasha @igordmn