Multiplatform support for navigation-compose
#1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
force-pushed
the
ivan.matkov/navigation-jb-main
branch
2 times, most recently
from
e7b0419
to
113fe26
Compare
Change-Id: I665f326038bc773530c2cbec2dd16f5ba98144e6
Change-Id: Ifc350a9bdfeaafe1165eef25d143b261eb17f623 Provide navigator name for multiplatform Change-Id: If39996aab30aaeb9253ea8ac0412ac9916918cc4 Fixup navigation-common [navigation-common] Expect `NavDeepLink` in common Remove annotation from jb navigator
Change-Id: I0a35d82ccdecd78d1034fdf37af741f496676c6f
Change-Id: I0074272aedcd099cb38fd65fc9e61823c4fac3ca
Change-Id: Ice1ecd1e06e1626677809016f8fa5e6ab212931b
[navigation-compose] Expect navigators [navigation-compose] Provide manual BackStackEntryIdViewModel factory Workaround for "Symbol is unbound" [navigation-compose] Fix missing project dependencies
MatkovIvan
force-pushed
the
ivan.matkov/navigation-jb-main
branch
from
113fe26
to
c574c9b
Compare
terrakok
approved these changes
Mar 25, 2024
igordmn
approved these changes
Mar 25, 2024
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
navigation-common,navigation-runtimeandnavigation-compose(Predictive)BackHandlernavigation-composeTesting
Test: run mpp sample. There are no commonized unit tests yet (TBD)
Usage example: https://github.com/MatkovIvan/nav_cupcake
Fixed Issues
Fixes JetBrains/compose-multiplatform#85
** DO NOT SQUASH **