Fix web key mappings #1249
Merged
Fix web key mappings #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Apr 9, 2024
compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/bug/BugReproducers.kt
Outdated
Show resolved
Hide resolved
Schahen
approved these changes
Apr 9, 2024
| canvasElement.dispatchEvent(createTypedEvent('e')) | ||
| canvasElement.dispatchEvent(createTypedEvent('s')) | ||
| canvasElement.dispatchEvent(createTypedEvent('t')) | ||
| assertEquals(Key.T, lastKeyEvent!!.key) |
There was a problem hiding this comment.
I might be missing something but how we are sure that this is the last "t"-event, not the first one?
There was a problem hiding this comment.
Changed the tests to avoid this potential issue.
| val KeyEventMappingsBugReproducer = Screen.Example("KeyEventMappingsBugReproducer (web)") { | ||
| val focusRequester = remember { FocusRequester() } | ||
| Box(Modifier.size(1000.dp).background(Color.Red).focusRequester(focusRequester).focusTarget().onKeyEvent { | ||
| println("" + it.key + " " + it.type) |
There was a problem hiding this comment.
I'd rather have test for all printable symbols - like sendKey(Key.Something) => actual value of the input is something
There was a problem hiding this comment.
I prefer to explicitly test 'onKeyEvent' here and the values of key event.
Changed the tests to check A..Z, 0..9 range.
MatkovIvan
approved these changes
Apr 9, 2024
MatkovIvan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for: JetBrains/compose-multiplatform#3644
Also a test for onPreviewKeyEvent issue (JetBrains/compose-multiplatform#2296)