Fix animation frozen after app went background #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
approved these changes
Apr 12, 2024
MatkovIvan
reviewed
Apr 12, 2024
compose/mpp/demo/src/uikitMain/kotlin/androidx/compose/mpp/demo/bugs/AnimationFreezeBug.kt
Show resolved
Hide resolved
MatkovIvan
requested changes
Apr 12, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Apr 12, 2024
elijah-semyonov
force-pushed
the
es/ios-animation-freeze-fix
branch
from
c6b320e
to
d4f81ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Invalidate compose scene when the app goes foreground to trigger redraw.
The intent is to avoid the situation where last presented frames are discarded due to the app going background, leaving the visual content in older state.
Testing
Test: Demo/IosBugs/AnimationFreezeBug the visual state always matches the animation final state when app goes to foreground.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4566