Set the ComposeSceneLayer's content in DisposableEffect rather than in the composition #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
force-pushed
the
m-sasha/fix-new-composition-setup
branch
from
e4ed692
to
4cc3e32
Compare
m-sasha
requested review from
igordmn,
igoriakovlev and
MatkovIvan
and removed request for
igoriakovlev
MatkovIvan
reviewed
Apr 16, 2024
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeSceneLayer.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeSceneLayer.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeSceneLayer.skiko.kt
Show resolved
Hide resolved
m-sasha
force-pushed
the
m-sasha/fix-new-composition-setup
branch
from
4cc3e32
to
38fca69
Compare
…an in the composition.
m-sasha
force-pushed
the
m-sasha/fix-new-composition-setup
branch
from
38fca69
to
f297f73
Compare
igordmn
approved these changes
Apr 16, 2024
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeSceneLayer.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeSceneLayer.skiko.kt
Show resolved
Hide resolved
igordmn
reviewed
Apr 17, 2024
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeSceneLayer.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeSceneLayer.skiko.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently set the
ComposeSceneLayer's content in the composition phase of its parent. This causes the initial state reads and writes of the child composition to register in the parent composition, which then breaks recomposition when the values of these states changes.See the discussion in Slack.
RelNote: Fix initial composition of
Dialogto correctly respond to changes of states that were both written and read in it. This fixes, for example,DateRangePickerignoring first date change after being shown.Proposed Changes
Move setting the layer's content into a
DisposableEffect.Testing
Test: Tested manually and added a new unit test.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4609