Restore button filter for dialog closing #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
May 2, 2024
m-sasha
approved these changes
May 2, 2024
Comment on lines
+77
to
+80
| private var outsidePointerCallback: (( | ||
| eventType: PointerEventType, | ||
| button: PointerButton? | ||
| ) -> Unit)? = null |
There was a problem hiding this comment.
Or some event type with reduced scope as parameter. But the problem here - it should be public
igordmn
pushed a commit
that referenced
this pull request
May 2, 2024
Fine tune #1280 change. The problem is some components like bottom sheet or navigation drawer define custom scrim and detect click on them via regular detection like `detectTapGestures` (that filters only primary mouse button). So to keep things consistent, we need to revert primary button filtering for `Dialog`, but keep it as-is for `Popup` to avoid breaking dropdowns, ## Testing Unit test: `DialogTest` Try to close `Popup` and `Dialog` by outside click via mouse buttons and touch. This should be tested by QA ## Release Notes ### Fixes - Desktop - _(prerelease fix)_ Fix inconsistency in closing `Dialog` by mouse clicking on scrim that was introduced by `1.6.10-beta02`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fine tune #1280 change. The problem is some components like bottom sheet or navigation drawer define custom scrim and detect click on them via regular detection like
detectTapGestures(that filters only primary mouse button). So to keep things consistent, we need to revert primary button filtering forDialog, but keep it as-is forPopupto avoid breaking dropdowns,Testing
Unit test:
DialogTestTry to close
PopupandDialogby outside click via mouse buttons and touch.This should be tested by QA
Release Notes
Fixes - Desktop
Dialogby mouse clicking on scrim that was introduced by1.6.10-beta02